CodeFuse IDE Support Web IDE #32 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacke2
reviewed
Nov 11, 2024
Cyrusky
reviewed
Nov 25, 2024
Cyrusky
reviewed
Nov 25, 2024
src/web/browser/common-modules.ts
Outdated
There was a problem hiding this comment.
I think bootstrap-web is better than web as dir name.
Cyrusky
reviewed
Nov 25, 2024
src/web/browser/common-modules.ts
Outdated
| DesignModule, | ||
| AINativeModule, | ||
| AIFeatureModule, | ||
| AutoUpdaterModule, |
There was a problem hiding this comment.
AutoUpdateModule is not necessary in a web environment.
src/web/browser/index.ts
Outdated
| import { layoutConfig } from './layout-config'; | ||
| import './main.less'; | ||
| import './styles.less'; | ||
| import {AILayout} from "@opensumi/ide-ai-native/lib/browser/layout/ai-layout"; |
There was a problem hiding this comment.
Please follow ESlint and Prettier rules.
|
I can not run your code, there are a lot of packages missed, I don't think you commit all the files you changed. like |
Closed
Cyrusky
reviewed
Nov 25, 2024
There was a problem hiding this comment.
By the way, Why mixed using the 'ts' and 'js' in the mean time ?
Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 6.0.5 to 6.0.6. - [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/v6.0.6/CHANGELOG.md) - [Commits](moxystudio/node-cross-spawn@v6.0.5...v6.0.6) --- updated-dependencies: - dependency-name: cross-spawn dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit e1e7ae7)
…se-ai#58) Bumps [@electron-forge/cli](https://github.com/electron/forge) from 7.4.0 to 7.5.0. - [Release notes](https://github.com/electron/forge/releases) - [Changelog](https://github.com/electron/forge/blob/main/CHANGELOG.md) - [Commits](electron/forge@v7.4.0...v7.5.0) --- updated-dependencies: - dependency-name: "@electron-forge/cli" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit b1e2b05)
…e-ai#59) Bumps [app-builder-lib](https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib) from 24.13.3 to 25.1.8. - [Release notes](https://github.com/electron-userland/electron-builder/releases) - [Changelog](https://github.com/electron-userland/electron-builder/blob/master/packages/app-builder-lib/CHANGELOG.md) - [Commits](https://github.com/electron-userland/electron-builder/commits/[email protected]/packages/app-builder-lib) --- updated-dependencies: - dependency-name: app-builder-lib dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 191729d)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 771e23b)
…e-ai#64) Bumps [webpack-dev-server](https://github.com/webpack/webpack-dev-server) from 5.0.4 to 5.1.0. - [Release notes](https://github.com/webpack/webpack-dev-server/releases) - [Changelog](https://github.com/webpack/webpack-dev-server/blob/master/CHANGELOG.md) - [Commits](webpack/webpack-dev-server@v5.0.4...v5.1.0) --- updated-dependencies: - dependency-name: webpack-dev-server dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit c6707aa)
eedpublic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#32 CodeFuse IDE Support Web IDE