Skip to content

Commit

Permalink
fix(ProConnectButton): ProConnect is out! (#315)
Browse files Browse the repository at this point in the history
* fix: conflict between proconnect and franceconnect buttons

* fix: proconnect link, root domain is not available yet

* fix: franceconnect documentation link

* feat: hide AC & MCP buttons, shows PC button instead
  • Loading branch information
rdubigny authored Oct 7, 2024
1 parent 5604438 commit b563a8b
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 7 deletions.
3 changes: 1 addition & 2 deletions .storybook/preview.js
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,7 @@ const { getHardCodedWeight } = (() => {
"components/Stepper",
"components/Button",
"components/FranceConnectButton",
"components/AgentConnectButton",
"components/MonCompteProButton"
"components/ProConnectButton"
];

function getHardCodedWeight(kind) {
Expand Down
4 changes: 2 additions & 2 deletions src/ProConnectButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export const ProConnectButton = memo(
style={style}
ref={ref}
>
<Inner className={fr.cx("fr-btn", "fr-connect")} {...innerProps}>
<Inner className={cx(fr.cx("fr-btn", "fr-connect"), "pro-connect")} {...innerProps}>
<span className={cx(fr.cx("fr-connect__login"), classes.login)}>
S’identifier avec
</span>
Expand All @@ -63,7 +63,7 @@ export const ProConnectButton = memo(
</Inner>
<p>
<a
href={"https://proconnect.gouv.fr/"}
href={"https://www.proconnect.gouv.fr/"}
target="_blank"
rel="noopener"
title={`${t("what is service")} - ${t("new window")}`}
Expand Down
4 changes: 2 additions & 2 deletions src/assets/proconnect-btn.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion stories/FranceConnectButton.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const { meta, getStory } = getStoryFactory({
sectionName,
"wrappedComponent": { FranceConnectButton },
"description": `
- [See DSFR documentation](https://github.com/france-connect/Documentation-AgentConnect/blob/main/doc_fs/implementation_fca/bouton_fca.md)
- [See DSFR documentation](https://www.systeme-de-design.gouv.fr/composants-et-modeles/composants/bouton-franceconnect/)
- [See source code](https://github.com/codegouvfr/react-dsfr/blob/main/src/FranceConnectButton.tsx)`
});

Expand Down

0 comments on commit b563a8b

Please sign in to comment.