Feature/tooltip component #190
Conversation
src/Tooltip.tsx
Outdated
| aria-describedby={id} | ||
| id={`tooltip-owner-${id}`} | ||
| > | ||
| Information contextuelle |
There was a problem hiding this comment.
should we add transation here ?
There was a problem hiding this comment.
Yes you are welcome to!
This is not my work, I reopenned the PR because I merged it too rearly
There was a problem hiding this comment.
You can see my code review here: #176 (comment)
There was a problem hiding this comment.
adressed most of the review comments
There was a problem hiding this comment.
Some things to improve:
- click only works without children
revolunet
force-pushed
the
feature/tooltip-component
branch
from
f888e94
to
9f9ef21
Compare
|
@garronej oy! je peux pas te mettre en reviewer mais le coeur y est :) |
|
Top @revolunet, merci beaucoup! Juste un petit tips au passage quand on implémente des test type level de l'API il est aussi important de vailider qu'on à pas d'erreur de compilation que validé le fait qu'on ai des érreur de compilations attendu quand l'API n'est pas utiliser correctement. Example: function foo(x: number){}
// @ts-expect-error: Can't pass a string as argument
foo(""); |
No description provided.