fix: do not display empty <label></label>
#275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revolunet
approved these changes
Jul 11, 2024
|
Thanks ! |
|
Thanks! |
ddecrulle
added a commit
that referenced
this pull request
Jul 16, 2024
ddecrulle
added a commit
that referenced
this pull request
Aug 19, 2024
|
The DSFR components Checkbox, Radio, and Switch need the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The props
labelandhintTextare ReactNodes. They can therefore be null, undefined, or an empty string (""). In these cases, the rendered HTML will be an empty<label>tag. This PR fixes this issue.There is a side effect: if the provided
labelorhintTextis the booleanfalse, it will not be displayed. I don't think this is problematic; it will simply require casting the boolean to a string.