Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Move property to local variable on usage only in setUp() method in tests #1222

Merged
merged 1 commit into from
Nov 5, 2024
Merged

refactor: Move property to local variable on usage only in setUp() method in tests #1222

merged 1 commit into from
Nov 5, 2024
+2 −12

Conversation

samsonasik
Copy link
Member

Description
Use local variable when only used on setUp() method.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik
Copy link
Member Author

Ready to merge 👍

@datamweb datamweb added the refactor Pull requests that refactor code label Nov 5, 2024
datamweb
datamweb approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks🎉

@samsonasik
Copy link
Member Author

Thank you @datamweb for the review, let's merge ;)

@samsonasik samsonasik merged commit 86b62c4 into codeigniter4:develop Nov 5, 2024
37 checks passed
@samsonasik samsonasik deleted the refactor-move-property-to-local-var-on-test branch November 5, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @datamweb