-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Description of vmm/src/lib.rs (VMM Struct and Implementation) #24
base: main
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,107 @@ | |||
# [VMM Impl](../src/vmm/src/lib.rs) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mention the path to the code file here
VMM_Implementaion.md
Outdated
let kernel_load_addr = self.compute_kernel_load_addr(&load_result)?; | ||
let kernel_load_addr = self.compute_kernel_load_addr(&load_result)?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this is called twice?
- `guest_memory` - The guest memory object. It is created when the VMM starts. It is wrapped in a `GuestMemoryMmap` object that provides a safe interface to the guest memory. | ||
- `device_mgr` - The device manager object. It is created when the VMM starts. It is responsible for managing the devices attached to the VMM. | ||
- `event_mgr` - The event manager object. It is created when the VMM starts. It is responsible for managing the events that are generated by the devices attached to the VMM. | ||
- `exit_handler` - The exit handler object. It is created when the VMM starts. It is responsible for handling the VM exits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lot of redundancy in these statements. You can just say
exit_handler
: responsible for handling VM exits.
Minor Errors Fixed
No description provided.