Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description of vmm/src/lib.rs (VMM Struct and Implementation) #24

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ramrap
Copy link

@ramrap ramrap commented Sep 12, 2022

No description provided.

@ramrap ramrap changed the title Documentation of vmm/src/lib.rs (VMM Struct and Implementation) Description of vmm/src/lib.rs (VMM Struct and Implementation) Sep 12, 2022
@@ -0,0 +1,107 @@
# [VMM Impl](../src/vmm/src/lib.rs)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention the path to the code file here

Comment on lines 41 to 42
let kernel_load_addr = self.compute_kernel_load_addr(&load_result)?;
let kernel_load_addr = self.compute_kernel_load_addr(&load_result)?;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this is called twice?

Comment on lines +20 to +23
- `guest_memory` - The guest memory object. It is created when the VMM starts. It is wrapped in a `GuestMemoryMmap` object that provides a safe interface to the guest memory.
- `device_mgr` - The device manager object. It is created when the VMM starts. It is responsible for managing the devices attached to the VMM.
- `event_mgr` - The event manager object. It is created when the VMM starts. It is responsible for managing the events that are generated by the devices attached to the VMM.
- `exit_handler` - The exit handler object. It is created when the VMM starts. It is responsible for handling the VM exits.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lot of redundancy in these statements. You can just say
exit_handler: responsible for handling VM exits.

Minor Errors Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants