forked from NVIDIA/cutlass
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatting, pvc gemm args validation, onemkl cmake #159
Merged
aacostadiaz
merged 9 commits into
codeplaysoftware:sycl-develop
from
FMarno:evt_investigation_refactors
Dec 5, 2024
Merged
Formatting, pvc gemm args validation, onemkl cmake #159
aacostadiaz
merged 9 commits into
codeplaysoftware:sycl-develop
from
FMarno:evt_investigation_refactors
Dec 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FMarno
commented
Nov 20, 2024
FMarno
changed the title
Evt Investigation Refactors
Formatting and pvc gemm validation
Nov 22, 2024
FMarno
changed the title
Formatting and pvc gemm validation
Formatting and pvc gemm args validation
Nov 22, 2024
FMarno
force-pushed
the
evt_investigation_refactors
branch
from
November 28, 2024 14:47
7770f61
to
439808c
Compare
FMarno
changed the title
Formatting and pvc gemm args validation
Formatting, pvc gemm args validation, onemkl cmake
Nov 28, 2024
joeatodd
requested changes
Nov 28, 2024
FMarno
force-pushed
the
evt_investigation_refactors
branch
from
December 2, 2024 18:14
8dbe3ce
to
83e3c85
Compare
joeatodd
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - might be worth confirming the UPDATE_DISCONNECTED
won't break a fresh build.
t4c1
approved these changes
Dec 3, 2024
aacostadiaz
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple changes I noticed while looking into something.