Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting, pvc gemm args validation, onemkl cmake #159

Merged

Conversation

FMarno
Copy link
Collaborator

@FMarno FMarno commented Nov 20, 2024

A couple changes I noticed while looking into something.

@FMarno FMarno changed the title Evt Investigation Refactors Formatting and pvc gemm validation Nov 22, 2024
@FMarno FMarno changed the title Formatting and pvc gemm validation Formatting and pvc gemm args validation Nov 22, 2024
@FMarno FMarno force-pushed the evt_investigation_refactors branch from 7770f61 to 439808c Compare November 28, 2024 14:47
@FMarno FMarno changed the title Formatting and pvc gemm args validation Formatting, pvc gemm args validation, onemkl cmake Nov 28, 2024
examples/sycl/pvc/pvc_gemm.cpp Outdated Show resolved Hide resolved
cmake/onemkl.cmake Show resolved Hide resolved
cmake/onemkl.cmake Outdated Show resolved Hide resolved
@FMarno FMarno force-pushed the evt_investigation_refactors branch from 8dbe3ce to 83e3c85 Compare December 2, 2024 18:14
Copy link
Collaborator

@joeatodd joeatodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - might be worth confirming the UPDATE_DISCONNECTED won't break a fresh build.

cmake/onemkl.cmake Show resolved Hide resolved
include/cutlass/gemm/kernel/xe_gemm.hpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@aacostadiaz aacostadiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aacostadiaz aacostadiaz merged commit e6466a9 into codeplaysoftware:sycl-develop Dec 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants