Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable generic functions for 64-bit shuffles #171

Open
wants to merge 3 commits into
base: sycl-develop
Choose a base branch
from

Conversation

t4c1
Copy link
Collaborator

@t4c1 t4c1 commented Dec 9, 2024

Enable generic functions for 64-bit shuffles. This is a bugfix for example 61 (top k softmax).

Copy link
Collaborator

@joeatodd joeatodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 need to fix the return type in one case, and (possibly) add static_asserts?

include/cutlass/gpu_generics.h Outdated Show resolved Hide resolved
include/cutlass/gpu_generics.h Show resolved Hide resolved
Copy link
Collaborator

@aacostadiaz aacostadiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for fixing it.

@joeatodd joeatodd self-requested a review December 16, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants