Add XE MMA/copy atom #23
Conversation
Co-authored-by: Mehdi Goli <[email protected]>
| // int W = size<1>(traits.tensor) * sizeof(typename decltype(traits.tensor)::engine_type::value_type); | ||
| int W = size<1>(traits.tensor) * sizeof(typename TD::value_type); //TODO: inconsistent to give the size in elements but use vector for copy | ||
| auto [y, x] = src.data().coord_; | ||
| XE_2D_LOAD::copy(traits.tensor.data().get(), W, H, W, int2_{x, y}, &*dst.data()); |
There was a problem hiding this comment.
| XE_2D_LOAD::copy(traits.tensor.data().get(), W, H, W, int2_{x, y}, &*dst.data()); | |
| XE_2D_LOAD::copy(traits.tensor.data().get(), W, H, W, int2_{static_cast<int>(x), static_cast<int>(y)}, &*dst.data()); |
There was a problem hiding this comment.
What's the motivation for this suggestion? Why do you want to allow narrowing conversion?
There was a problem hiding this comment.
I am getting compile time errors when integrating this code into the PVC pipeline without the conversion.
There was a problem hiding this comment.
What tensor do you pass to the copy? What error do you get?
There was a problem hiding this comment.
Can we resolve this? Maybe by merging as-is and open an issue to discuss this. Otherwise we have the other PRs depending on this having to make changes later.
There was a problem hiding this comment.
I hope you don't mind I merged it without resolving this. Needed to clean up the PR dependency issue. Please open a new PR with your suggested change if you still think it is needed.
| int H = size<0>(traits.tensor); | ||
| int W = size<1>(traits.tensor) * sizeof(typename decltype(traits.tensor)::engine_type::value_type); | ||
| auto [y, x] = dst.data().coord_; | ||
| XE_2D_SAVE::copy(traits.tensor.data().get(), W, H, W, int2_{x, y}, &*src.data()); |
There was a problem hiding this comment.
| XE_2D_SAVE::copy(traits.tensor.data().get(), W, H, W, int2_{x, y}, &*src.data()); | |
| XE_2D_SAVE::copy(traits.tensor.data().get(), W, H, W, int2_{static_cast<int>(x), static_cast<int>(y)}, &*src.data()); |
No description provided.