Fix typo in Macro #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tware#16) * Updating README-sycl.md to capture the 3.5 modifications * Update README-sycl.md Co-authored-by: aacostadiaz <[email protected]> * Remove the sgemm_nt_1_sycl PoC (codeplaysoftware#15) * Remove sgemm_nt_1 PoC * Fix build issues * Fix code style format * Remove ENABLE_NVPTX flag * Update include/cute/util/debug.hpp Co-authored-by: Mehdi Goli <[email protected]> * Cosmetic --------- Co-authored-by: Mehdi Goli <[email protected]> * Applying the comments --------- Co-authored-by: aacostadiaz <[email protected]>
mehdi-goli
approved these changes
Apr 16, 2024
taozha2
pushed a commit
that referenced
this pull request
Apr 17, 2024
* Migrate cute components to SYCL (#19) * Migrate Cute components to SYCL * Add CMake configuration (#20) * Add cmake configuration * Update examples/cute/tutorial/CMakeLists.txt Co-authored-by: Mehdi Goli <[email protected]> --------- Co-authored-by: Mehdi Goli <[email protected]> * Update README-sycl.md (#22) * Update README-sycl.md Fixing CUDA version * Add XE MMA/copy atom * Update to 3.5 API * fixing device only code that get called in the host side (#25) * Fix GPU clock (#21) * Apply suggestions from code review Co-authored-by: Mehdi Goli <[email protected]> * Fix typo in Macro (#28) Fix typo in Macro Co-authored-by: Mehdi Goli <[email protected]> * Cosmetic --------- Co-authored-by: Mehdi Goli <[email protected]> * Applying the comments --------- Co-authored-by: aacostadiaz <[email protected]> * Revert "Updating README-sycl.md to capture the 3.5 modifications (#16)" (#17) This reverts commit a726bd3. * fix typo in macro --------- Co-authored-by: Mehdi Goli <[email protected]> Co-authored-by: aacostadiaz <[email protected]> --------- Co-authored-by: Atharva Dubey <[email protected]> Co-authored-by: aacostadiaz <[email protected]> Co-authored-by: Mehdi Goli <[email protected]>
jiyang1011
pushed a commit
to jiyang1011/cutlass-fork
that referenced
this pull request
Apr 24, 2024
…playsoftware#29) * Migrate cute components to SYCL (codeplaysoftware#19) * Migrate Cute components to SYCL * Add CMake configuration (codeplaysoftware#20) * Add cmake configuration * Update examples/cute/tutorial/CMakeLists.txt Co-authored-by: Mehdi Goli <[email protected]> --------- Co-authored-by: Mehdi Goli <[email protected]> * Update README-sycl.md (codeplaysoftware#22) * Update README-sycl.md Fixing CUDA version * Add XE MMA/copy atom * Update to 3.5 API * fixing device only code that get called in the host side (codeplaysoftware#25) * Fix GPU clock (codeplaysoftware#21) * Apply suggestions from code review Co-authored-by: Mehdi Goli <[email protected]> * Fix typo in Macro (codeplaysoftware#28) Fix typo in Macro Co-authored-by: Mehdi Goli <[email protected]> * Cosmetic --------- Co-authored-by: Mehdi Goli <[email protected]> * Applying the comments --------- Co-authored-by: aacostadiaz <[email protected]> * Revert "Updating README-sycl.md to capture the 3.5 modifications (codeplaysoftware#16)" (codeplaysoftware#17) This reverts commit a726bd3. * fix typo in macro --------- Co-authored-by: Mehdi Goli <[email protected]> Co-authored-by: aacostadiaz <[email protected]> --------- Co-authored-by: Atharva Dubey <[email protected]> Co-authored-by: aacostadiaz <[email protected]> Co-authored-by: Mehdi Goli <[email protected]> Add pvc example (codeplaysoftware#26) * Migrate cute components to SYCL (codeplaysoftware#19) * Migrate Cute components to SYCL * Add CMake configuration (codeplaysoftware#20) * Add cmake configuration * Update examples/cute/tutorial/CMakeLists.txt Co-authored-by: Mehdi Goli <[email protected]> --------- Co-authored-by: Mehdi Goli <[email protected]> * Update README-sycl.md (codeplaysoftware#22) * Update README-sycl.md Fixing CUDA version * Add XE MMA/copy atom * Update to 3.5 API * Add example * Update include/cute/util/sycl_vec.hpp Co-authored-by: Mehdi Goli <[email protected]> * Update include/cute/atom/mma_traits_xe.hpp Co-authored-by: Mehdi Goli <[email protected]> * Update include/cute/atom/copy_traits_xe.hpp Co-authored-by: Mehdi Goli <[email protected]> * Update include/cute/atom/mma_atom.hpp Co-authored-by: Mehdi Goli <[email protected]> * Update include/cute/arch/mma_xe.hpp Co-authored-by: Mehdi Goli <[email protected]> --------- Co-authored-by: Atharva Dubey <[email protected]> Co-authored-by: aacostadiaz <[email protected]> Co-authored-by: Mehdi Goli <[email protected]> Co-authored-by: Roland Schulz <[email protected]> add prefetch, mkl validation, and group partition misc refine Make atom type a make_2d_copy argument Use cute::bfloat16_t add KK=2 enable btile prefetch, got 250Tflops (codeplaysoftware#4) direct big tile, got 280Tflops remove unused code and add more print (codeplaysoftware#7) enable unaligned shape like 4098 (codeplaysoftware#9) add barrier and wait enable big tile modify some datatype
jiyang1011
pushed a commit
to jiyang1011/cutlass-fork
that referenced
this pull request
Apr 29, 2024
…playsoftware#29) * Migrate cute components to SYCL (codeplaysoftware#19) * Migrate Cute components to SYCL * Add CMake configuration (codeplaysoftware#20) * Add cmake configuration * Update examples/cute/tutorial/CMakeLists.txt Co-authored-by: Mehdi Goli <[email protected]> --------- Co-authored-by: Mehdi Goli <[email protected]> * Update README-sycl.md (codeplaysoftware#22) * Update README-sycl.md Fixing CUDA version * Add XE MMA/copy atom * Update to 3.5 API * fixing device only code that get called in the host side (codeplaysoftware#25) * Fix GPU clock (codeplaysoftware#21) * Apply suggestions from code review Co-authored-by: Mehdi Goli <[email protected]> * Fix typo in Macro (codeplaysoftware#28) Fix typo in Macro Co-authored-by: Mehdi Goli <[email protected]> * Cosmetic --------- Co-authored-by: Mehdi Goli <[email protected]> * Applying the comments --------- Co-authored-by: aacostadiaz <[email protected]> * Revert "Updating README-sycl.md to capture the 3.5 modifications (codeplaysoftware#16)" (codeplaysoftware#17) This reverts commit a726bd3. * fix typo in macro --------- Co-authored-by: Mehdi Goli <[email protected]> Co-authored-by: aacostadiaz <[email protected]> --------- Co-authored-by: Atharva Dubey <[email protected]> Co-authored-by: aacostadiaz <[email protected]> Co-authored-by: Mehdi Goli <[email protected]>
jiyang1011
pushed a commit
to jiyang1011/cutlass-fork
that referenced
this pull request
Apr 29, 2024
Fix typo in Macro Co-authored-by: Mehdi Goli <[email protected]> * Cosmetic --------- Co-authored-by: Mehdi Goli <[email protected]> * Applying the comments --------- Co-authored-by: aacostadiaz <[email protected]> * Revert "Updating README-sycl.md to capture the 3.5 modifications (codeplaysoftware#16)" (codeplaysoftware#17) This reverts commit a726bd3. * fix typo in macro --------- Co-authored-by: Mehdi Goli <[email protected]> Co-authored-by: aacostadiaz <[email protected]>
jiyang1011
pushed a commit
to jiyang1011/cutlass-fork
that referenced
this pull request
Apr 29, 2024
…playsoftware#29) * Migrate cute components to SYCL (codeplaysoftware#19) * Migrate Cute components to SYCL * Add CMake configuration (codeplaysoftware#20) * Add cmake configuration * Update examples/cute/tutorial/CMakeLists.txt Co-authored-by: Mehdi Goli <[email protected]> --------- Co-authored-by: Mehdi Goli <[email protected]> * Update README-sycl.md (codeplaysoftware#22) * Update README-sycl.md Fixing CUDA version * Add XE MMA/copy atom * Update to 3.5 API * fixing device only code that get called in the host side (codeplaysoftware#25) * Fix GPU clock (codeplaysoftware#21) * Apply suggestions from code review Co-authored-by: Mehdi Goli <[email protected]> * Fix typo in Macro (codeplaysoftware#28) Fix typo in Macro Co-authored-by: Mehdi Goli <[email protected]> * Cosmetic --------- Co-authored-by: Mehdi Goli <[email protected]> * Applying the comments --------- Co-authored-by: aacostadiaz <[email protected]> * Revert "Updating README-sycl.md to capture the 3.5 modifications (codeplaysoftware#16)" (codeplaysoftware#17) This reverts commit a726bd3. * fix typo in macro --------- Co-authored-by: Mehdi Goli <[email protected]> Co-authored-by: aacostadiaz <[email protected]> --------- Co-authored-by: Atharva Dubey <[email protected]> Co-authored-by: aacostadiaz <[email protected]> Co-authored-by: Mehdi Goli <[email protected]>
AD2605
added a commit
to AD2605/cutlass-fork
that referenced
this pull request
May 24, 2024
Fix typo in Macro Co-authored-by: Mehdi Goli <[email protected]> * Cosmetic --------- Co-authored-by: Mehdi Goli <[email protected]> * Applying the comments --------- Co-authored-by: aacostadiaz <[email protected]> * Revert "Updating README-sycl.md to capture the 3.5 modifications (codeplaysoftware#16)" (codeplaysoftware#17) This reverts commit a726bd3. * fix typo in macro --------- Co-authored-by: Mehdi Goli <[email protected]> Co-authored-by: aacostadiaz <[email protected]>
aacostadiaz
added a commit
that referenced
this pull request
Jul 16, 2024
Fix typo in Macro Co-authored-by: Mehdi Goli <[email protected]> * Cosmetic --------- Co-authored-by: Mehdi Goli <[email protected]> * Applying the comments --------- Co-authored-by: aacostadiaz <[email protected]> * Revert "Updating README-sycl.md to capture the 3.5 modifications (#16)" (#17) This reverts commit a726bd3. * fix typo in macro --------- Co-authored-by: Mehdi Goli <[email protected]> Co-authored-by: aacostadiaz <[email protected]>
aacostadiaz
added a commit
to aacostadiaz/cutlass-fork
that referenced
this pull request
Aug 6, 2024
Fix typo in Macro Co-authored-by: Mehdi Goli <[email protected]> * Cosmetic --------- Co-authored-by: Mehdi Goli <[email protected]> * Applying the comments --------- Co-authored-by: aacostadiaz <[email protected]> * Revert "Updating README-sycl.md to capture the 3.5 modifications (codeplaysoftware#16)" (codeplaysoftware#17) This reverts commit a726bd3. * fix typo in macro --------- Co-authored-by: Mehdi Goli <[email protected]> Co-authored-by: aacostadiaz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the typo in macro introduced in #25