Fix bug with size operator call in tensor_foreach.h file #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AD2605
approved these changes
Jun 6, 2024
aacostadiaz
approved these changes
Jun 6, 2024
mehdi-goli
approved these changes
Jun 6, 2024
aacostadiaz
merged commit 67e39cf
into
codeplaysoftware:sycl-develop
3 of 4 checks passed
aacostadiaz
pushed a commit
to aacostadiaz/cutlass-fork
that referenced
this pull request
Jun 13, 2024
Fix a bug introduced in the tensor_foreach.h file. We cannot calculate the size of a Coord object by doing size(size), and instead we need to call product() method.
aacostadiaz
pushed a commit
that referenced
this pull request
Jul 16, 2024
Fix a bug introduced in the tensor_foreach.h file. We cannot calculate the size of a Coord object by doing size(size), and instead we need to call product() method.
aacostadiaz
pushed a commit
to aacostadiaz/cutlass-fork
that referenced
this pull request
Aug 6, 2024
Fix a bug introduced in the tensor_foreach.h file. We cannot calculate the size of a Coord object by doing size(size), and instead we need to call product() method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug introduced in the
tensor_foreach.hfile. We cannot calculate the size of aCoordobject by doingsize(size), and instead we need to callproduct()method. This is now fixed in the code.