-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"HOST" environment variable #6423
Conversation
Added "HOST" environment variable. It works the same way as the "PORT".
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6423 +/- ##
==========================================
+ Coverage 73.61% 73.64% +0.02%
==========================================
Files 31 31
Lines 1880 1882 +2
Branches 406 407 +1
==========================================
+ Hits 1384 1386 +2
Misses 419 419
Partials 77 77
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I love the addition of tests as well.
What do you think about making this CODE_SERVER_HOST
instead? I know we already have plain PORT
but we are trying to ensure new variables have unique names (and eventually we should add CODE_SERVER_PORT
and deprecate PORT
too).
I think it will be fine. Thanks for the review! |
Thank you for the input and the examples! Collisions like that are a really good reason we should use a unique prefix. For this PR let us go forward with |
Oh wait, were you saying that Heroku sets |
Yes :D Then I'll add a new commit for replacing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again, looks good!
Sounds like we will probably want to keep PORT
around then. I will keep that in mind!
Hi!
I added the "HOST" environment variable. It works the same way as the "PORT".
I also added tests for it depending on "PORT" tests.
Fixes #6422