feat: removed external dependencies (VPN, mutagen) connection management #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -189,7 +189,7 @@ private void SyncSessionStateChanged(object? sender, SyncSessionControllerStateM | |||
| UpdateSyncSessionState(syncSessionState); | |||
| } | |||
|
|
|||
| private void MaybeSetUnavailableMessage(RpcModel rpcModel, CredentialModel credentialModel) | |||
| private void MaybeSetUnavailableMessage(RpcModel rpcModel, CredentialModel credentialModel, SyncSessionControllerStateModel? syncSessionState = null) | |||
There was a problem hiding this comment.
I think you should just update the couple of places we call it to always include the sync model, otherwise if we get an RPC update after a sync update we will potentially unset UnavailableMessage
Comment on lines
+3
to
+10
| using Coder.Desktop.App.Views.Pages; | ||
| using CommunityToolkit.Mvvm.ComponentModel; | ||
| using CommunityToolkit.Mvvm.Input; | ||
| using Microsoft.UI.Xaml; | ||
| using Microsoft.UI.Xaml.Controls; | ||
| using System; | ||
| using System.Diagnostics; | ||
| using System.Threading.Tasks; |
There was a problem hiding this comment.
Do you use any of these new imports? It doesn't seem like you're using any new types (except maybe System.Exception) in the code
Comment on lines
+33
to
+35
| <TextBlock TextWrapping="Wrap" Foreground="Red" Visibility="{x:Bind ViewModel.ReconnectFailed, Converter={StaticResource BoolToVisibilityConverter}, Mode=OneWay}"> | ||
| <Bold>Reconnect failed</Bold> | ||
| </TextBlock> |
There was a problem hiding this comment.
Could you just do TextWeight instead? See TrayWindowMainPage.xaml and look at the Workspaces header (I think)
Comment on lines
+2
to
+4
| using Microsoft.UI.Xaml; | ||
| using Microsoft.UI.Xaml.Controls; | ||
| using System; |
|
|
||
| syncSessionCts.Dispose(); | ||
| }, CancellationToken.None); | ||
| _ = Task.Delay(5000).ContinueWith((_) => |
There was a problem hiding this comment.
Should add a comment explaining why we do this. I think the explanation of "it seems to be a race" is good enough for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #68