Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a 1m timeout to signal shutdown #92

Merged
merged 5 commits into from
Aug 21, 2024
Merged

fix: add a 1m timeout to signal shutdown #92

merged 5 commits into from
Aug 21, 2024

Conversation

sreya
Copy link
Collaborator

@sreya sreya commented Aug 21, 2024

  • It's possible for a number of reasons for the bootstrap script
    to not exit. This PR adds a hard timeout of 1 minute before
    we forcefully exit.

sreya added 5 commits August 21, 2024 21:11
- It's possible for a number of reasons for the bootstrap script
  to not exit. This PR adds a hard timeout of 1 minute before
  we forcefully exit.
@sreya sreya merged commit 0d37a62 into main Aug 21, 2024
9 checks passed
@sreya sreya deleted the jon/fixhang branch August 21, 2024 23:26
sreya added a commit that referenced this pull request Aug 22, 2024
sreya added a commit that referenced this pull request Aug 22, 2024
* Revert "fix: add a 1m timeout to signal shutdown (#92)"

This reverts commit 0d37a62.

* Revert "fix: pass through signals to inner container (#83)"

This reverts commit c07d2c2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant