Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent build logs from crashing envbox process #95

Merged
merged 2 commits into from
Aug 22, 2024
Merged

fix: prevent build logs from crashing envbox process #95

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd475ce
fix: prevent build logs from crashing envbox process
sreya Aug 22, 2024
9693f46
Merge branch 'main' into jon/nonfatalbuildlogs
sreya Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions cli/docker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,13 +180,15 @@ func dockerCmd(ch chan func() error) *cobra.Command {

agent, err := buildlog.OpenCoderClient(ctx, coderURL, log, flags.agentToken)
if err != nil {
return xerrors.Errorf("open coder client: %w", err)
// Don't fail workspace startup on
// an inability to push build logs.
log.Error(ctx, "failed to instantiate coder build log client, no logs will be pushed", slog.Error(err))
} else {
blog = buildlog.MultiLogger(
buildlog.OpenCoderLogger(ctx, agent, log),
blog,
)
}

blog = buildlog.MultiLogger(
buildlog.OpenCoderLogger(ctx, agent, log),
blog,
)
}
defer blog.Close()

Expand Down
Loading