Apply suggestions from code review

Co-authored-by: Mathias Fredriksson <[email protected]>
coder · Sep 25, 2024 · 591b0c0 · 591b0c0
1 parent 8e8483b
commit 591b0c0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -43,7 +43,7 @@ jobs:
           bun lint
           # check for version changes
           ./update-version.sh
-          if [[ $(git status --porcelain) ]]; then
+          if [[ -n "$(git status --porcelain)" ]]; then
             echo "Version mismatch. Please run ./update-version.sh"
             git diff
             exit 1

diff --git a/update-version.sh b/update-version.sh
@@ -39,7 +39,7 @@ for dir in "${changed_dirs[@]}"; do
     }' "$file" > "$tmpfile" && mv "$tmpfile" "$file"
 
     # Check if the README.md file has changed
-    if ! git diff --quiet "$dir/README.md"; then
+    if ! git diff --quiet -- "$dir/README.md"; then
       echo "Bumping version in $dir/README.md"
     fi
   fi
@@ -48,7 +48,7 @@ done
 # Check if any changes were made in README.md files
 if [[ -n "$(git status --porcelain -- '**/README.md')" ]]; then
   echo "Version mismatch detected. Please commit the updated README.md files."
-  git diff '**/README.md'  # Show what is different in the README.md files
+  git diff -- '**/README.md'  # Show what is different in the README.md files
   exit 1
 else
   echo "No version mismatch detected. All versions are up to date."