-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup all test files #293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment to prevent any possible merge conflicts for #287. Otherwise all look good to me.
@Parkreiner, all modules are merged. You may continue with the refactoring here, |
"target": "esnext", | ||
"module": "nodenext", | ||
// If we were just compiling for the tests, we could safely target ESNext at | ||
// all times, but just because we've been starting to add more runtime logic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only have the runtime logic in the windows-rdp module, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now, yeah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But one of the other benefits of having an older compilation target is that, because I have that JavaScript file set up to be part of the TypeScript project, the TypeScript LSP can catch any function calls that might be using features that are too recent
For linting, let us use biomejs, which is similar to a coder/coder. I am using biome vscode extension that does help catch these errors. |
No issue to link – this is just something I thought I could fix really quickly while working in the codebase.
Changes made
any
typesNotes