Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kasmVNC): fix debian installation and improve logging #326

Merged
merged 4 commits into from
Oct 21, 2024
+5 −3
Merged

fix(kasmVNC): fix debian installation and improve logging #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aa341a9
Update run.sh
djarbz Oct 19, 2024
64b51c3
Quiet Curl
djarbz Oct 19, 2024
8c94eaa
Silence APT
djarbz Oct 19, 2024
c10501b
Update README.md
djarbz Oct 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kasmvnc/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Automatically install [KasmVNC](https://kasmweb.com/kasmvnc) in a workspace, and
```tf
module "kasmvnc" {
source = "registry.coder.com/modules/kasmvnc/coder"
version = "1.0.21"
version = "1.0.22"
agent_id = coder_agent.example.id
desktop_environment = "xfce"
}
Expand Down
6 changes: 4 additions & 2 deletions kasmvnc/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ download_file() {
if command -v wget &> /dev/null; then
wget $url -O $output
elif command -v curl &> /dev/null; then
curl -L $url -o $output
curl -fsSL $url -o $output
elif command -v busybox &> /dev/null; then
busybox wget -O $output $url
else
Expand All @@ -32,7 +32,8 @@ download_file() {
install_deb() {
local url=$1
download_file $url /tmp/kasmvncserver.deb
sudo apt-get install --yes --no-install-recommends --no-install-suggests /tmp/kasmvncserver.deb
sudo apt-get update
DEBIAN_FRONTEND=noninteractive sudo apt-get install --yes -qq --no-install-recommends --no-install-suggests /tmp/kasmvncserver.deb
sudo adduser $USER ssl-cert
rm /tmp/kasmvncserver.deb
}
Expand Down Expand Up @@ -103,6 +104,7 @@ fi

# Check if vncserver is installed, and install if not
if ! check_installed; then
echo "Installing KASM version: ${VERSION}"
case $distro in
ubuntu | debian | kali)
case $version in
Expand Down