Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jetbrains-gateway): add releases_base_link/download_base_link variables #333

Merged
merged 6 commits into from
Oct 30, 2024

Conversation

kerwin612
Copy link
Contributor

  • Enhance the jetbrains-gateway module to support custom download link.

In offline mode, the currently configured offline download address will be overridden by the parameters of jetbrains-gateway(jetbrains-gateway://connect#......&ide_download_link=https://download.jetbrains.com/idea/ideaIU-XXX.tar.gz).

Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the contribution.
Could you also add some instructions in README.md on how one can set up custom jetbrains hosting?

Also, please take a look at failing tests and bump the version using ./scripts/update-version.sh

Comment on lines 75 to 90
### Custom base link

```tf
module "jetbrains_gateway" {
source = "registry.coder.com/modules/jetbrains-gateway/coder"
version = "1.0.21"
agent_id = coder_agent.example.id
agent_name = "example"
folder = "/home/coder/example"
jetbrains_ides = ["GO", "WS"]
releases_base_link = "https://releases.internal.site/"
download_base_link = "https://download.internal.site/"
default = "GO"
}
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This example is helpful. But can you also add on how one can set up internal serving for JetBrains IDEs? Thanks

@matifali
Copy link
Member

Hi @kerwin612, could you run bun install && bun update-version to bump the module version?
Thanks.

@matifali matifali merged commit 8785470 into coder:main Oct 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants