-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: integrate Instatus in check script #342
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matifali
force-pushed
the
atif/modules-health
branch
from
November 18, 2024 16:59
eb80759
to
19f05e1
Compare
- Improve monitoring by implementing Instatus API to update component status based on module check results. - Automate incident reports for module failures to enable efficient troubleshooting.
matifali
force-pushed
the
atif/modules-health
branch
from
November 18, 2024 17:01
19f05e1
to
33e4ba8
Compare
johnstcn
reviewed
Nov 18, 2024
Comment on lines
+19
to
+26
update_component_status() { | ||
local component_status=$1 | ||
# see https://instatus.com/help/api/components | ||
(curl -X PUT "https://api.instatus.com/v1/$INSTATUS_PAGE_ID/components/$INSTATUS_COMPONENT_ID" \ | ||
-H "Authorization: Bearer $INSTATUS_API_KEY" \ | ||
-H "Content-Type: application/json" \ | ||
-d "{\"status\": \"$component_status\"}") | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we check for the required InStatus environment variables being set upfront and exit with a non-zero exit status if not provided? Right now we will exit with
./.github/scripts/check.sh: line 22: INSTATUS_PAGE_ID: unbound variable
johnstcn
approved these changes
Nov 19, 2024
matifali
added a commit
that referenced
this pull request
Nov 20, 2024
- Introduce Amazon DCV for remote desktop on Windows workspaces. - Script to install and configure DCV components. - Terraform setup for configuring resources like coder_app. - Ensure secure management with sensitive variable handling. chore: add health check badge (#341) chore: integrate Instatus in check script (#342)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Instatus API support to monitor module status.