Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jetbrains-gateway): bump to 2024.3 #355

Merged
merged 7 commits into from
Nov 29, 2024
Merged

Conversation

matifali
Copy link
Member

@matifali matifali commented Nov 27, 2024

Bumps default IDE versions to 2024.3
Set the default value of latest=true to always fetch the latest versions.

Extracted from #339 as that introduces a breaking change.

@matifali matifali requested review from bpmct and phorcys420 November 27, 2024 11:35
jetbrains-gateway/README.md Outdated Show resolved Hide resolved
jetbrains-gateway/main.tf Show resolved Hide resolved
Copy link
Member

@phorcys420 phorcys420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except what Danny already pointed out

@matifali matifali changed the title feat(jetbrains-gateway): bump to 2024.3 and enable fetching latest feat(jetbrains-gateway): bump to 2024.3 and enable fetching latest by default Nov 27, 2024
@matifali matifali requested a review from mafredri November 27, 2024 18:02
@matifali
Copy link
Member Author

@mafredri I need some help with ./update-versions.sh as it is trying to bump the nested versions too.

@mafredri
Copy link
Member

@matifali taking a look 👍🏻

mafredri added a commit that referenced this pull request Nov 28, 2024
…ng version

The script was too greedy and updating unrelated fields in #355.

This change makes the script much more strict, only updating version on the top-level.
@bpmct bpmct removed their request for review November 29, 2024 14:07
@matifali matifali changed the title feat(jetbrains-gateway): bump to 2024.3 and enable fetching latest by default feat(jetbrains-gateway): bump to 2024.3 Nov 29, 2024
@matifali matifali enabled auto-merge (squash) November 29, 2024 15:51
@matifali matifali merged commit 675c823 into main Nov 29, 2024
2 checks passed
@matifali matifali deleted the atif/update-gateway-latest branch November 29, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants