fixup! feat: add magicsock opt to block direct endpoints

coder · Nov 22, 2023 · 614a18f · 614a18f
1 parent d8aa41d
commit 614a18f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/wgengine/magicsock/magicsock.go b/wgengine/magicsock/magicsock.go
@@ -431,6 +431,7 @@ func NewConn(opts Options) (*Conn, error) {
 	c.logf = opts.logf()
 	c.epFunc = opts.endpointsFunc()
 	c.derpActiveFunc = opts.derpActiveFunc()
+	c.blockEndpoints = opts.BlockEndpoints
 	c.idleFunc = opts.IdleFunc
 	c.testOnlyPacketListener = opts.TestOnlyPacketListener
 	c.noteRecvActivity = opts.NoteRecvActivity

diff --git a/wgengine/magicsock/magicsock_test.go b/wgengine/magicsock/magicsock_test.go
@@ -3112,14 +3112,13 @@ func TestBlockEndpointsDERPOK(t *testing.T) {
 func waitForNoEndpoints(t *testing.T, ms *Conn) {
 	t.Helper()
 	ok := false
-parentLoop:
 	for i := 0; i < 50; i++ {
 		time.Sleep(100 * time.Millisecond)
 		ms.mu.Lock()
-		for _, ep := range ms.lastEndpoints {
-			t.Errorf("endpoint %v was not blocked", ep.Addr)
+		if len(ms.lastEndpoints) != 0 {
+			t.Errorf("some endpoints were not blocked: %v", ms.lastEndpoints)
 			ms.mu.Unlock()
-			continue parentLoop
+			continue
 		}
 		ms.mu.Unlock()
 		ok = true