chore: avoid logging netcheck send errors if STUN is disabled #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coadler
reviewed
Sep 19, 2023
tailcfg/derpmap.go
Outdated
| func (m *DERPMap) HasSTUN() bool { | ||
| for _, r := range m.Regions { | ||
| for _, n := range r.Nodes { | ||
| if n.STUNPort > 0 && !n.STUNOnly { |
There was a problem hiding this comment.
I think we had this bug before, STUNPort: 0 just means the defaullt port. I'm confused on the !n.STUNOnly too, why would you want to exclude STUN only nodes?
There was a problem hiding this comment.
Changed to if n.StunPort >= 0
coadler
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a confusing log line to customers and happens when STUN is disabled. Also avoids the constant rebinding every 20 seconds which is pointless since we're not using the UDP socket at all in these situations.