feat: add magicsock opt to block direct endpoints #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spikecurtis
reviewed
Nov 22, 2023
spikecurtis
approved these changes
Nov 28, 2023
|
Tests fail due to outdated fork doing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, BlockEndpoints was only implemented on Coder's side in the coordination protocol and by removing STUN servers from the DERP map. This had some gaps though... local endpoints gathered from interfaces on the PC would still be gathered and could still be sent to the other peer using disco call-me-maybe packets.
This disables storing (and therefore sending) any endpoints using a runtime-controllable setting on magicsock.
The UDP socket and portmapper are still created (for now) as removing them fully did not seem trivial without causing many bugs in the process.
Updates coder/coder#10791