Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
counter_packets_dropped_reason
metric is using incorrect labels, probably because a reason was dropped and a new one added to the end, causing the reasons between to be shifted out of alignment with their labels in the metrics.The actual reasons are
I noticed this while looking into DERP performance, since I was seeing a bunch of drops for
gone_not_here
which is not a valid reason in present version.