fix: set TCPMaxRetries to 5 for reasonable timeouts on send #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @spikecurtis and the rest of your teammates on |
deansheather
approved these changes
Sep 20, 2024
sreya
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: coder/coder#14712
SSH can hang for a really long time if you lose connectivity to your workspace, e.g. lose WiFi moving your laptop around, etc. If you're running
coder sshit becomes just an unresponsive terminal, and you have to open a new terminal to kill the process.This PR configures our TCP connections with gVisor so that they time out in 15-30s if you try to send data and don't get a response. That amount of time should allow Tailscale/Wireguard to reconnect if possible, while not making the user wait around a ton of time if it's just never going to work, based on their (lack of) network connectivity.