Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add coderd_provisioner_key resource #141

Merged
merged 9 commits into from
Nov 15, 2024
Merged

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Nov 15, 2024

These are immutable once created, so really only Create and Delete need implementations. Everything gets stored in Terraform state (including the secret, since it cannot be reacquired any other way).

A change in any attribute must trigger a full replace of the resource.

Copy link
Member

@ethanndickson ethanndickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resource is missing the markdown documentation, but CI is passing without make gen having been run 🤔 will fix

internal/provider/provisioner_key_resource.go Outdated Show resolved Hide resolved
internal/provider/provisioner_key_resource_test.go Outdated Show resolved Hide resolved
internal/provider/provisioner_key_resource.go Outdated Show resolved Hide resolved
ethanndickson added a commit that referenced this pull request Nov 15, 2024
Discovered in #141 that CI could pass even when `make gen` could produce
a new file.
@aslilac aslilac marked this pull request as ready for review November 15, 2024 20:57
@aslilac aslilac merged commit e90acf0 into main Nov 15, 2024
13 checks passed
@aslilac aslilac deleted the lilac/provisioner_key branch November 15, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants