chore: add acceptance tests to user resource #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
coadler
force-pushed
the
colin/chore_add_acceptance_tests_to_user_resource
branch
from
150ca52 to
c59c745
Compare
matifali
reviewed
Jul 13, 2024
| - "1.1.*" | ||
| - "1.2.*" | ||
| - "1.3.*" | ||
| - "1.4.*" | ||
| - "1.5.*" | ||
| - "1.6.*" | ||
| - "1.7.*" | ||
| - "1.8.*" |
There was a problem hiding this comment.
As only 1.8 and 1.9 are supported versions and others have gone into end of life and also we can only test for versions that we include in our supported coder releases.
There was a problem hiding this comment.
Unless this causes maintenance issues I'm inclined to leave this as-is until we want to decide on a support window. It looks like our other terraform provider supports back to 1.5
deansheather
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.