Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate resources against available features before creating #62

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Aug 6, 2024

Closes #61

We can't actually validate the fields during the plan, as we don't have access to the provider data store (with the *codersdk.Client) during plan modification, or validation.
Instead we do it during Create for enterprise-only resources, and Create and Update for templates.

Copy link
Member Author

ethanndickson commented Aug 6, 2024

@ethanndickson ethanndickson force-pushed the 08-06-fix_validate_resources_against_available_features_before_creating branch from aad8947 to a5e6e53 Compare August 6, 2024 11:31
@ethanndickson ethanndickson force-pushed the 08-01-fix_template_version_replacement_metadata_updates branch from ef38461 to b02f6a8 Compare August 6, 2024 13:59
@ethanndickson ethanndickson force-pushed the 08-06-fix_validate_resources_against_available_features_before_creating branch from a5e6e53 to db62dcc Compare August 6, 2024 13:59
@ethanndickson ethanndickson force-pushed the 08-01-fix_template_version_replacement_metadata_updates branch from b02f6a8 to eaab432 Compare August 7, 2024 05:54
@ethanndickson ethanndickson force-pushed the 08-06-fix_validate_resources_against_available_features_before_creating branch from db62dcc to 04f9b53 Compare August 7, 2024 05:54
@ethanndickson ethanndickson force-pushed the 08-01-fix_template_version_replacement_metadata_updates branch from eaab432 to cd6a681 Compare August 7, 2024 05:56
@ethanndickson ethanndickson force-pushed the 08-06-fix_validate_resources_against_available_features_before_creating branch from 04f9b53 to 41956b0 Compare August 7, 2024 05:56
@ethanndickson ethanndickson changed the base branch from 08-01-fix_template_version_replacement_metadata_updates to graphite-base/62 August 7, 2024 05:57
@ethanndickson ethanndickson force-pushed the 08-06-fix_validate_resources_against_available_features_before_creating branch from 41956b0 to 19a4577 Compare August 7, 2024 05:57
@ethanndickson ethanndickson changed the base branch from graphite-base/62 to main August 7, 2024 05:58
@ethanndickson ethanndickson marked this pull request as ready for review August 9, 2024 00:53
@ethanndickson ethanndickson force-pushed the 08-06-fix_validate_resources_against_available_features_before_creating branch from 19a4577 to 31a1a2b Compare August 9, 2024 00:53
internal/provider/group_resource.go Outdated Show resolved Hide resolved
@ethanndickson ethanndickson force-pushed the 08-06-fix_validate_resources_against_available_features_before_creating branch from 31a1a2b to d5b4ace Compare August 9, 2024 07:08
@ethanndickson ethanndickson merged commit b768a21 into main Aug 9, 2024
14 checks passed
@ethanndickson ethanndickson deleted the 08-06-fix_validate_resources_against_available_features_before_creating branch August 19, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate enterprise-only fields during plan
2 participants