Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the view logs command #392

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Fix the view logs command #392

merged 1 commit into from
Nov 1, 2024

Conversation

code-asher
Copy link
Member

The command was opening the old log path.

@code-asher code-asher force-pushed the asher/fix-open-log-command branch 2 times, most recently from b0a965f to 8e20d82 Compare October 31, 2024 18:40
The command was opening the old log path.
@code-asher code-asher force-pushed the asher/fix-open-log-command branch from 8e20d82 to 897002a Compare October 31, 2024 18:49
@code-asher code-asher self-assigned this Nov 1, 2024
Copy link
Contributor

@bcpeinhardt bcpeinhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcpeinhardt
Copy link
Contributor

I think maybe we can flag this as something an E2E test would have caught?

@code-asher
Copy link
Member Author

I think maybe we can flag this as something an E2E test would have caught?

Definitely!

@code-asher code-asher merged commit 8cc079f into main Nov 1, 2024
2 checks passed
@code-asher code-asher deleted the asher/fix-open-log-command branch November 1, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants