added detailed guide in echo readme.md example folder #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why checks are failing i just added text in example docs..... i am new let me know if anyone sees my comment here |
|
@nhooyr ... |
mafredri
reviewed
Aug 21, 2024
| @@ -1,3 +1,3 @@ | |||
| module nhooyr.io/websocket | |||
|
|
|||
| go 1.19 | |||
| go 1.22.5 | |||
There was a problem hiding this comment.
We want to retain go 1.19 compatibility for now, bumping to 1.22 is too big a jump anyway as 1.20 would be the next one.
|
|
||
| 1. Project starts. `func main` as the entry point start the program. | ||
|
|
||
| 2. main func execute `run()` and `log.Fatal` is there is `err` |
There was a problem hiding this comment.
This is too much detail. This is obvious from reading the code.
|
Closing, feel free to open a new PR or issue if there's a specific concern you'd like addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have just updated echo readme,nd example files because most go users are confused including please accept my pr, you can also edit it a little bit if you want or let me know if you need anything else, thanks for the lib