feat: Update NSTemplateTier CRD so that it contains the Spec.Parameters and the Status.Revisions fields #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfrancisc
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19 and
sbryzak
as code owners
Co-authored-by: Alexey Kazakov <[email protected]>
alexeykazakov
approved these changes
Sep 12, 2024
MatousJobanek
approved these changes
Sep 16, 2024
Co-authored-by: Matous Jobanek <[email protected]>
Co-authored-by: Matous Jobanek <[email protected]>
Co-authored-by: Matous Jobanek <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two optional fields:
NSTemplateTier.Spec.Parameterswill contain all the parameters that will be evaluated in the TierTemplates referenced by NSTemplateTier. Those parameters will be evaluated at creation time, thus when the NSTemplateTier and TierTemplate CRs are created in the cluster.NSTemplateTier.Status.Revisionsis a list containing the names of the last applied TierTemplateRevisions CR and they will be used to generate the unique hash as we do now with the TierTemplate names.For more details see NSTemplateSet creation/update scenario in the design doc
Jira: https://issues.redhat.com/browse/KUBESAW-136
Checks
Did you run
make generatetarget? yesDid
make generatechange anything in other projects (host-operator)? yesIn case of new CRD, did you the following? N/A
resources/setup/roles/host.yamlin the sandbox-sre repositoryPROJECTfile: https://github.com/codeready-toolchain/host-operator/blob/master/PROJECTCSVfile: https://github.com/codeready-toolchain/host-operator/blob/master/config/manifests/bases/host-operator.clusterserviceversion.yamlIn case other projects are changed, please provides PR links.