Create tc based on creds secret #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
controller that uses kubeconfig to initialize the cluster connections.
…n-creds-secret # Conflicts: # go.sum
metlos
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
|
/retest |
…n-creds-secret # Conflicts: # go.mod # go.sum
|
/retest |
…n-creds-secret # Conflicts: # go.mod # go.sum
… into create-tc-based-on-creds-secret
|
alexeykazakov
approved these changes
Sep 5, 2024
MatousJobanek
approved these changes
Sep 5, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, MatousJobanek, metlos The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1058 +/- ##
==========================================
- Coverage 85.07% 85.05% -0.02%
==========================================
Files 55 55
Lines 5038 5038
==========================================
- Hits 4286 4285 -1
- Misses 581 582 +1
Partials 171 171 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the host operator with a new version of toolchain-common to add support for initializing the cluster connections from the kubeconfig in toolchain cluster secrets.
Related PRs: