Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update NSTemplateSet CRD #596

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

mfrancisc
Copy link
Contributor

@mfrancisc mfrancisc commented Sep 17, 2024

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.56%. Comparing base (f80135a) to head (658ab38).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #596   +/-   ##
=======================================
  Coverage   83.56%   83.56%           
=======================================
  Files          28       28           
  Lines        2604     2604           
=======================================
  Hits         2176     2176           
  Misses        288      288           
  Partials      140      140           

Copy link

openshift-ci bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alexeykazakov,mfrancisc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

sonarcloud bot commented Sep 23, 2024

@mfrancisc mfrancisc merged commit 7e4e153 into codeready-toolchain:master Sep 25, 2024
11 of 12 checks passed
@mfrancisc mfrancisc deleted the updatenstemplateset branch September 25, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants