Skip to content

Conversation

juntuu
Copy link
Collaborator

@juntuu juntuu commented Feb 25, 2021

This could:

  1. allow compiling with gcc 10.2, accompishing the same as Add workaround for compile error on stricter C++ compilers #164
  2. allow for compiler upgrade to clang 11 / gcc 10
  3. point 2 would enable c++17 features and Fix handling of .. in jepath() (requires <filesystem> header) #170 would compile

Tested with the following compiler versions on osx:

; /usr/local/Cellar/gcc/10.2.0_4/bin/gcc-10 --version
gcc-10 (Homebrew GCC 10.2.0_4) 10.2.0
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
; clang --version
Apple clang version 12.0.0 (clang-1200.0.32.29)
Target: x86_64-apple-darwin20.3.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

Allows compiling with gcc 10.2
@herwinw
Copy link
Contributor

herwinw commented Feb 25, 2021

Just tested this, it fixes the problems I previously encountered, and this fix doesn't require stupid wrapper functions in C around every conflicting call.

/me approves

@codereport codereport added the ci / build This pertains to CI / build label Feb 25, 2021
@codereport codereport merged commit 0c1e1fe into codereport:main Feb 25, 2021
@juntuu juntuu deleted the compiler-upgrade branch February 27, 2021 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci / build This pertains to CI / build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants