Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 76 make bingo page #178

Merged
merged 20 commits into from
Feb 14, 2025
Merged

Issue 76 make bingo page #178

merged 20 commits into from
Feb 14, 2025

Conversation

mye9
Copy link
Contributor

@mye9 mye9 commented Feb 10, 2025

Change Summary

Finish the implementation of both mobile and desktop version in blingo page

Change Form

Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

  • The pull request title has an issue number
  • The change works by "Smoke testing" or quick testing
  • The change has tests
  • The change has documentation

Other Information

[Is there anything in particular in the review that I should be aware of?]

Related issue

Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blingo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 7:25am

client/src/views/BlingoView.vue Outdated Show resolved Hide resolved
client/src/views/BlingoView.vue Outdated Show resolved Hide resolved
client/src/views/BlingoView.vue Show resolved Hide resolved
client/src/views/BlingoView.vue Show resolved Hide resolved
client/src/views/BlingoView.vue Outdated Show resolved Hide resolved
Copy link
Member

@HuxleyBerry HuxleyBerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on the fixes! I've noticed a couple of minor additional problems.

client/src/components/ChallengeCard.vue Outdated Show resolved Hide resolved
client/src/components/ChallengeCard.vue Outdated Show resolved Hide resolved
client/src/components/ChallengeCard.vue Outdated Show resolved Hide resolved
client/src/views/BlingoView.vue Show resolved Hide resolved
Copy link
Member

@HuxleyBerry HuxleyBerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WTTheCoder WTTheCoder merged commit 80f35af into main Feb 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make bingo page
3 participants