Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 154 create profiles page #188

Merged
merged 17 commits into from
Feb 14, 2025
Merged

Issue 154 create profiles page #188

merged 17 commits into from
Feb 14, 2025

Conversation

aradavi63
Copy link
Contributor

@aradavi63 aradavi63 commented Feb 14, 2025 •
edited by github-actions bot
Loading

Change Summary

Change Form

Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

  • The pull request title has an issue number
  • The change works by "Smoke testing" or quick testing
  • The change has tests
  • The change has documentation

Other Information

  • I just decided to push this early to look for feedback, apparently Zichen still has some UI changes he wants to do but hasn't done yet
  • If you log in as a user, navigating to http://localhost:3000/profile displays the profile page for a user called 'currentuser', and overrides your account, instead of actually displaying the profile of the logged in user, so this needs to be fixed

Related issue

survivzhang and others added 16 commits February 6, 2025 15:39
@survivzhang
maybe not correct
67b99e7
@aradavi63
move everything ProfileView.vue, which was previously a temporary vie…
8b37b7b 
…w to check the ChallengeInteraction component
@aradavi63
move stuff into more appropriately named files
4bed7b3
@aradavi63
Hide finishDate and description if challenge still 'In Progress'
16c9bd5
@aradavi63
deleted unnecessary test file
f7011c3
@aradavi63
delete test route
3302548
@survivzhang
delete some chinese comment
cdb7b1e
@23348918 @HuxleyBerry @survivzhang
Issue 118 create api view to fetch other user s completed challenges (#…
180fc75 
…156)

* added utils check access and response for no access

* added returning challenges info

* succeeded test case, excluded image for now

* added image urls, fixed dates

* converted to use serializer

* test cases refactored and working

* minor merge changes

* flake8

* added requested changes

* remove image files

---------

Co-authored-by: HuxleyBerry <[email protected]>
@HuxleyBerry @survivzhang
update avatars, update ocean youth logo (#180)
cc93571
@survivzhang
add mockdata to test
7a25a75
@survivzhang
Removed the duplicate 404 route and catch-all route (/:pathMatch(.*)*)
8bfd4f1
@survivzhang
add current user data more reality
87248b7
@survivzhang
if not logIn redirect to login modal, if logIn redirect to normal page
c958652
@aradavi63
Merge remote-tracking branch 'origin/main' into issue-154-Create_prof…
bc49a18 
…iles_page
@aradavi63
update header
afeda80
@survivzhang
Successful test just have UI thing to do
201d614
@vercel Vercel
Copy link

vercel bot commented Feb 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blingo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 9:18am

HuxleyBerry
HuxleyBerry approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@HuxleyBerry HuxleyBerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd like to get this page into main ASAP so that it can be connected to the backend. We can worry about the minor UI improvements later.

@HuxleyBerry HuxleyBerry merged commit 8919bb5 into main Feb 14, 2025
7 checks passed
@HuxleyBerry HuxleyBerry deleted the issue-154-Create_profiles_page branch February 14, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuxleyBerry HuxleyBerry HuxleyBerry approved these changes

Assignees

@survivzhang survivzhang

@aradavi63 aradavi63

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create profiles page
4 participants
@aradavi63 @HuxleyBerry @survivzhang @23348918