Fix embed sandbox does not hide navigation above 1280px width #8685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes codesandbox#7347 Add functionality to hide the split pane in embed mode when `hideNavigation` is set. * Add a new state variable `hideSplitPane` to the `State` type definition in `packages/app/src/embed/components/App/index.js`. * Initialize `hideSplitPane` state variable in the constructor based on `hideNavigation`. * Update the `render` method to conditionally render the `SplitView` component based on `hideSplitPane`. * Add a new prop `hideSplitPane` to the `SplitView` component in `packages/app/src/embed/components/SplitPane/index.js`. * Update the `SplitView` component to conditionally render the resizer based on `hideSplitPane`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/codesandbox/codesandbox-client/issues/7347?shareId=XXXX-XXXX-XXXX-XXXX).
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7347
Add functionality to hide the split pane in embed mode when
hideNavigationis set.hideSplitPaneto theStatetype definition inpackages/app/src/embed/components/App/index.js.hideSplitPanestate variable in the constructor based onhideNavigation.rendermethod to conditionally render theSplitViewcomponent based onhideSplitPane.hideSplitPaneto theSplitViewcomponent inpackages/app/src/embed/components/SplitPane/index.js.SplitViewcomponent to conditionally render the resizer based onhideSplitPane.For more details, open the Copilot Workspace session.