-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implementation of router, navigation bar and settings. #38
base: development_2.0.0
Are you sure you want to change the base?
Conversation
Branch name should be 'base branch + a descriptive name for changes done in the PR'. Change branch name to development_2.0_add_routes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, just small comments.
- Settings title should be aligned with page content
- check if old pass in settings is true
- change settings fs to 1.7rem
- add :disabled="!form?.isValid || loading" to all forms
Good job ya 3obad, i just have some comments
|
Why it shouldn't accept social characters btw Screencast.from.08-27-2024.10.30.08.AM.webmAfter I pressed Screencast.from.08-27-2024.10.32.40.AM.webmWhen the users press submit, you have to send their
Also, I should be able to update the email if there is no email associated Same happening in the Passwords form, The loading button was loading forever, the request API URL wasn't valid |
Description
Create routes for the website and Create a navigation bar to use the router.
Changes
Related Issues