TLS: add support for TLS key logging #120
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds support for logging TLS keys akin to the `SSLKEYLOGFILE` support found in `curl` and various browsers. Doing so allows TLS traffic to be decrypted by tools like Wireshark which is very useful for debugging. ## Changes - add `--key-log-path` to `args_parser` and propagate through `config` - `client_cert` opens the file (creating if necessary) and then parses it to `tls.Config.KeyLogWriter` so that the TLS layer does the rest of the hard work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for logging TLS keys akin to the
SSLKEYLOGFILEsupport found incurland various browsers. Doing so allows TLS traffic to be decrypted by tools like Wireshark which is very useful for debugging.--key-log-pathtoargs_parserand propagate throughconfigclient_certopens the file (creating if necessary) and then passes it totls.Config.KeyLogWriterso that the TLS layer does the rest of the hard work