Print new api key #60
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: OliverTrautvetter <[email protected]>
NautiluX
reviewed
Oct 30, 2025
| It("should detect the old format and attempt to upgrade", func() { | ||
| cmd := exec.Command(cliPath, "version") | ||
| cmd.Env = append(os.Environ(), | ||
| "OMS_PORTAL_API_KEY=U4jsSHoDsOFGyEkPrWpsE", // 22 characters |
There was a problem hiding this comment.
can we use something that's more obviously not a real API KEY like fakeapikeywith22charsa?
| } | ||
| opts.OmsPortalApiKey = newApiKey | ||
|
|
||
| fmt.Fprintf(os.Stderr, "Successfully upgraded API key to new format!\n") |
There was a problem hiding this comment.
I think this output is confusing and should be removed. This command will use the new env var, but outside, nothing will change right? So it's more a performance optimization for this specific execution of oms-cli. Not sure if it's even worth doing?
NautiluX
reviewed
Nov 3, 2025
| fmt.Fprintf(os.Stderr, "Attempting to upgrade to the new format...\n\n") | ||
|
|
||
| portalClient := portal.NewPortalClient() | ||
| newApiKey, err := portalClient.GetApiKeyByHeader(apiKey) |
There was a problem hiding this comment.
I think it should be possible to concatenate the new API key in the client and only query the key ID from the portal, WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat: Auto-upgrade and output legacy API Keys
Implements logic in the OMS CLI to detect and handle legacy API keys. The CLI will now automatically query the OMS Portal to retrieve the missing Key ID, generate the new concatenated API key (
key_id + key), and output the new format to the user. This simplifies the user experience during the key migration.CU Card (ClickUp Task)