network: support for uPnP and PMP nat traversal #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmega
reviewed
Dec 20, 2024
munna0908
force-pushed
the
feature/nat-traversal
branch
from
fbcf01e to
b387b6a
Compare
gmega
reviewed
Jan 7, 2025
|
@veaceslavdoina @benbierens Rahul is making some changes to the way NAT parameters work, we should make sure that all users of those (e.g. testnet deployers, disttests deployers) are not gonna fall apart, would be good to have your eyes here. |
gmega
approved these changes
Jan 7, 2025
dryajov
approved these changes
Jan 8, 2025
codex/utils/addrutils.nim
Outdated
| else: | ||
| none(Port) | ||
|
|
||
| result = (ip: ip, port: port) |
There was a problem hiding this comment.
Setting result explicitly is usually unnecessary (and in fact, can cause issues under certain condition). Nim will return whatever the result of the last evaluation of the selected codepath is.
Suggested change
| result = (ip: ip, port: port) | |
| (ip: ip, port: port) |
codex/nat.nim
Outdated
| of true: extIp*: ValidIpAddress | ||
| of false: nat*: NatStrategy | ||
|
|
||
| func parseCmdArg*(T: type NatConfig, p: string): T {.raises: [ValueError].} = |
There was a problem hiding this comment.
By convention, we keep this in the conf.nim.
- remove Disc_ip env - update CODE_NAT parsing logic
munna0908
force-pushed
the
feature/nat-traversal
branch
from
2bae744 to
0934e59
Compare
|
If you're done addressing the comments, @munna0908, feel free to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for new NAT traversal techniques. Issue: #905
Changes Include
natCLI flag: Allowing users to select from various options for determining the public address. The available options are:disc-ipflag: The IP address will now be automatically parsed from the provided listener address