-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nix service definition for codex #1062
Merged
Merged
+128
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markoburcul
force-pushed
the
add-nix-codex-service-definition
branch
3 times, most recently
from
January 9, 2025 17:22
20f597f
to
9135d7c
Compare
jakubgs
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you've over-done it with defining every single setting, but it's not a bad thing :D.
Also, a README might benefit from an example of how to use the service.
markoburcul
force-pushed
the
add-nix-codex-service-definition
branch
5 times, most recently
from
January 9, 2025 19:09
2ed0281
to
08d7fbd
Compare
jakubgs
reviewed
Jan 9, 2025
markoburcul
force-pushed
the
add-nix-codex-service-definition
branch
2 times, most recently
from
January 10, 2025 15:43
72d764e
to
7bddd4a
Compare
markoburcul
changed the title
WIP: add nix service definition for codex
Add nix service definition for codex
Jan 10, 2025
markoburcul
force-pushed
the
add-nix-codex-service-definition
branch
from
January 10, 2025 16:10
7bddd4a
to
25edac0
Compare
Signed-off-by: markoburcul <[email protected]>
Referenced issue: #940 Signed-off-by: markoburcul <[email protected]>
markoburcul
force-pushed
the
add-nix-codex-service-definition
branch
from
January 10, 2025 16:49
25edac0
to
0cffa02
Compare
Readme doesn't have an example of how to load the service module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added service definition for Nim Codex and tests.
The service can be instantiated by including it in flake inputs:
and configuring the service: