Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nix service definition for codex #1062

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

markoburcul
Copy link
Contributor

@markoburcul markoburcul commented Jan 9, 2025

Added service definition for Nim Codex and tests.
The service can be instantiated by including it in flake inputs:

  inputs = {
    nixpkgs.url = "github:NixOS/nixpkgs/nixos-24.11";
    codex-flake.url = "git+https://github.com/codex-storage/nim-codex?submodules=1#";
  };

and configuring the service:

services.nim-codex = {
   enable = true;
   settings = {
       data-dir = "/var/lib/codex-test";
   };
};

@markoburcul markoburcul requested a review from jakubgs January 9, 2025 13:33
@markoburcul markoburcul force-pushed the add-nix-codex-service-definition branch 3 times, most recently from 20f597f to 9135d7c Compare January 9, 2025 17:22
Copy link

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you've over-done it with defining every single setting, but it's not a bad thing :D.

Also, a README might benefit from an example of how to use the service.

nix/codex.nix Outdated Show resolved Hide resolved
nix/codex.nix Outdated Show resolved Hide resolved
nix/codex.nix Outdated Show resolved Hide resolved
@markoburcul markoburcul force-pushed the add-nix-codex-service-definition branch 5 times, most recently from 2ed0281 to 08d7fbd Compare January 9, 2025 19:09
nix/codex.nix Outdated Show resolved Hide resolved
nix/codex.nix Outdated Show resolved Hide resolved
nix/codex.nix Outdated Show resolved Hide resolved
nix/codex.nix Outdated Show resolved Hide resolved
nix/codex.nix Outdated Show resolved Hide resolved
@markoburcul markoburcul force-pushed the add-nix-codex-service-definition branch 2 times, most recently from 72d764e to 7bddd4a Compare January 10, 2025 15:43
@markoburcul markoburcul marked this pull request as ready for review January 10, 2025 15:43
@markoburcul markoburcul changed the title WIP: add nix service definition for codex Add nix service definition for codex Jan 10, 2025
@markoburcul markoburcul force-pushed the add-nix-codex-service-definition branch from 7bddd4a to 25edac0 Compare January 10, 2025 16:10
@markoburcul markoburcul enabled auto-merge January 10, 2025 16:42
@markoburcul markoburcul disabled auto-merge January 10, 2025 16:43
@markoburcul markoburcul force-pushed the add-nix-codex-service-definition branch from 25edac0 to 0cffa02 Compare January 10, 2025 16:49
@markoburcul markoburcul merged commit 0cffa02 into master Jan 10, 2025
14 checks passed
@markoburcul markoburcul deleted the add-nix-codex-service-definition branch January 10, 2025 16:51
@jakubgs
Copy link

jakubgs commented Jan 10, 2025

Readme doesn't have an example of how to load the service module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants