Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use increaseAllowance for token approving #565

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Conversation

AuHau
Copy link
Member

@AuHau AuHau commented Oct 9, 2023

No description provided.

emizzle
emizzle previously approved these changes Oct 9, 2023
Copy link
Contributor

@emizzle emizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emizzle
Copy link
Contributor

emizzle commented Oct 10, 2023

After our discussion last night, this may no longer be needed. See #550 (comment) for the changes needed to avoid reliance on increaseAllowance. Also related: codex-storage/codex-contracts-eth#68

@AuHau AuHau marked this pull request as ready for review October 16, 2023 09:31
@AuHau AuHau merged commit 5f4218b into master Oct 16, 2023
8 checks passed
@AuHau AuHau deleted the fix/increase-allowance branch October 16, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants