Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(logging): purchases logging #567

Merged
merged 4 commits into from
Oct 19, 2023
Merged

chore(logging): purchases logging #567

merged 4 commits into from
Oct 19, 2023

Conversation

AuHau
Copy link
Member

@AuHau AuHau commented Oct 17, 2023

Adds some basic logging for the purchases state machine following how it is done in sales.

emizzle
emizzle previously approved these changes Oct 18, 2023
Copy link
Contributor

@emizzle emizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the spacing and failing tests, LGTM.

codex/purchasing/states/cancelled.nim Outdated Show resolved Hide resolved
markspanbroek
markspanbroek previously approved these changes Oct 18, 2023
Copy link
Member

@markspanbroek markspanbroek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from failing test, looks good. Thanks @AuHau!

codex/purchasing/states/submitted.nim Outdated Show resolved Hide resolved
@AuHau AuHau merged commit c28627d into master Oct 19, 2023
8 checks passed
@AuHau AuHau deleted the chore/purchase-logging branch October 19, 2023 08:12
dryajov pushed a commit that referenced this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants