fix: Redirect to 404 Page When Note is Not Found

src/application/i18n/messages/en.json

@@ -177,6 +177,7 @@
     "marketplace": "Marketplace",
     "addTool": "Add tool",
     "notFound": "Not found",
+    "unexpectedError": "Unexpected error",
     "joinTeam": "Join",
     "authorization": "Authorize",
     "history": "History",

src/application/router/routes.ts

@@ -195,6 +195,18 @@ const routes: RouteRecordRaw[] = [
       code: 404,
     },
   },
+  {
+    path: '/500',
+    component: ErrorPage,
+    meta: {
+      layout: 'fullpage',
+      pageTitleI18n: 'pages.unexpectedError',
+      discardTabOnLeave: true,
+    },
+    props: {
+      code: 500,
+    },
+  },
 ];
 
 export default routes;

src/application/services/useNote.ts

@@ -5,6 +5,7 @@ import type { NoteTool } from '@/domain/entities/Note';
 import { useRouter, useRoute } from 'vue-router';
 import type { NoteDraft } from '@/domain/entities/NoteDraft';
 import type EditorTool from '@/domain/entities/EditorTool';
+import ApiError from '@/domain/entities/errors/ApiError';
 import useHeader from './useHeader';
 import { getTitle } from '@/infrastructure/utils/note';
 
@@ -166,12 +167,20 @@ export default function (options: UseNoteComposableOptions): UseNoteComposableSt
     /**
      * @todo try-catch domain errors
      */
-    const response = await noteService.getNoteById(id);
-
-    note.value = response.note;
-    canEdit.value = response.accessRights.canEdit;
-    noteTools.value = response.tools;
-    parentNote.value = response.parentNote;
+    try {
+      const response = await noteService.getNoteById(id);
+
+      note.value = response.note;
+      canEdit.value = response.accessRights.canEdit;
+      noteTools.value = response.tools;
+      parentNote.value = response.parentNote;
+    } catch (error) {
+      if (error instanceof ApiError) {
+        void router.push('/500');
+      } else {
+        void router.push('/400');
+      }
+    }
   }
 
   /**

src/domain/entities/errors/ApiError.ts

@@ -0,0 +1,16 @@
+import DomainError from './Base';
+
+/**
+ * Domain error thrown when some resource is not found
+ */
+export default class ApiError extends DomainError {
+  /**
+   * Constructor for ApiError error
+   * @param message - Error message
+   * @param statusCode - Error status code
+   */
+  constructor(message: string, public statusCode: number) {
+    super(message);
+    this.name = 'ApiError';
+  }
+}

src/infrastructure/transport/notes-api/index.ts

@@ -5,6 +5,7 @@ import AuthorizableTransport from '@/infrastructure/transport/authorizable.trans
 import type JSONValue from '../types/JSONValue';
 import UnauthorizedError from '@/domain/entities/errors/Unauthorized';
 import NotFoundError from '@/domain/entities/errors/NotFound';
+import ApiError from '@/domain/entities/errors/ApiError';
 import type { FilesDto } from '../types/FileDto';
 
 /**
@@ -53,7 +54,7 @@ export default class NotesApiTransport extends AuthorizableTransport {
           case 404:
             return new NotFoundError(errorText);
           default:
-            return new Error(errorText);
+            return new ApiError(errorText, status);
         }
       },
     });