[Feature] Select component for Codex UI #279
Open
+114
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Dropdown component implementation, but in component only one option is selectable. Also updated icons package version in package json's
neSpecc
reviewed
Nov 28, 2024
| > | ||
| {{ activeItem.title }} | ||
| </Button> | ||
| <div :style="showPopover ? {'display' : 'block'} : {'display': 'none'}"> |
There was a problem hiding this comment.
use the Popover component as a wrapper
|
why file in |
Changed Component's name from Select to Dropdown; Converting options list into Popover component
e11sy
previously requested changes
Dec 3, 2024
Comment on lines
79
to
84
| &__btn { | ||
| user-select: none; | ||
| background-color: var(--base--bg-secondary); | ||
| margin-bottom: var(--spacing-s); | ||
| padding-right: var(--spacing-s); | ||
| } |
Comment on lines
85
to
89
| &__btn:hover { | ||
| background-color: var(--base--bg-secondary-hover); | ||
| cursor: pointer; | ||
| } | ||
| } |
codex-ui/dev/routes.ts
Outdated
Comment on lines
89
to
90
| path: '/components/dropdown', | ||
| component: Dropdown as Component, |
There was a problem hiding this comment.
why select component is removed? you need to add new dropdown component, not to override select
| if (item.type === 'default' || !item.type) { | ||
| activeItem.value = Object.create(item); | ||
| // eslint-disable-next-line no-console | ||
| activeItem.value.onActivate = console.log; |
There was a problem hiding this comment.
onActivate will recieve no parameters, so logs would be empty.
Anyway, i think, that this loggs are unneeded in app, where this component would be used
There was a problem hiding this comment.
also this works wrong:
- If i open popover by pressing dropdown button, then isOpened becomes
true - Then i select any option in context menu, popover becomes hidden, and title of the button updates
- If i press popover button one more time it makes isOpened
falseand nothing changes on page (i expect popover to be opened again)
so we should manually hide() popover, when new item selected or popover closed by pressing anywhere else
Popover component's logic changed
There was some mess with component's name, because Dropdown and Select lots in common, so now this is Select component Also added ability to toggle select by clicking on selection button
DeadCreator
changed the title
DeadCreator
requested review from
e11sy
and removed request for
neSpecc and
e11sy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Dropdown component implementation (#273), but in component only one option is selectable. Also updated icons package version in package json's