Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI workflow for C++ coverage generation and testing #571

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

nagajaideep
Copy link

References to other Issues or PRs or Relevant literature

Brief description of what is fixed or changed

  • Modified the CI workflow (ci.yml) to include steps for generating and uploading code coverage reports for the C++ modules.
  • Integrated gcov with necessary flags for accurate coverage measurement.
  • Ensured compatibility with existing build and test processes.

Other comments

run: |
mkdir -p build
cd build
cmake -DCMAKE_CXX_FLAGS="--coverage" ..
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the right way. Nice attempt though.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this part of the code for now sir ,will work on it after the current issue

@@ -37,7 +37,29 @@ jobs:
- name: Build package
run: |
python scripts/build/install.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, just do, CXXFLAGS=--coverage CFLAGS=--coverage python scripts/build/install.py.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above should work.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made the changes in ci.yml file

.github/workflows/ci.yml Show resolved Hide resolved
@nagajaideep
Copy link
Author

image
how to tackel this issue sir?based upon my understanding it is not able create it or not able to edit it ?any steps to resolve this issue sir?

@nagajaideep
Copy link
Author

Hello sir @czgdp1807

image

I hope you're doing well. I noticed that the test is failing with the error -lcov not found. As per your earlier suggestion, I added lcov to the environment.yml file in this PR. However, it seems the test is still failing, which I believe could be since it is still not added in the main repo?

Could you kindly review this and let me know your thoughts on the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants