-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI workflow for C++ coverage generation and testing #571
base: main
Are you sure you want to change the base?
Conversation
.github/workflows/ci.yml
Outdated
run: | | ||
mkdir -p build | ||
cd build | ||
cmake -DCMAKE_CXX_FLAGS="--coverage" .. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the right way. Nice attempt though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed this part of the code for now sir ,will work on it after the current issue
.github/workflows/ci.yml
Outdated
@@ -37,7 +37,29 @@ jobs: | |||
- name: Build package | |||
run: | | |||
python scripts/build/install.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, just do, CXXFLAGS=--coverage CFLAGS=--coverage python scripts/build/install.py
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above should work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made the changes in ci.yml file
Hello sir @czgdp1807 I hope you're doing well. I noticed that the test is failing with the error -lcov not found. As per your earlier suggestion, I added lcov to the environment.yml file in this PR. However, it seems the test is still failing, which I believe could be since it is still not added in the main repo? Could you kindly review this and let me know your thoughts on the issue? |
References to other Issues or PRs or Relevant literature
Brief description of what is fixed or changed
ci.yml
) to include steps for generating and uploading code coverage reports for the C++ modules.gcov
with necessary flags for accurate coverage measurement.Other comments