-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support only Ruby 3.1 onwards #1526
base: develop
Are you sure you want to change the base?
Conversation
TODO list:
|
Would the badges be 2 test outcome badges, one for 3.1 and one for 3.2?
One possibility I was imagining was keeping this at 3.1 until a second pull request is merged on 2025-04-01 to change the testing to 3.2 and 3.3, and change the Docker config to use 3.2. Alternatively we could change the Docker config to use 3.2 in this pull request, and change it to use 3.3 on 2025-04-01. I don't know whether any instances are using Docker in production, and whether that would affect this decision. |
Don't have a strong opinion on that, but 2 badges, one for each target, sounds reasonable to me
d'oh, I haven't paid attention to the PR's description... Well, this item is mostly to ensure I don't forget to do so as promised, we can merge without it if I end up not being available to make good on that promise in a timely fashion. |
I had a look at the instructions for making a CircleCI badge. The current badge (at the top of the readme) appears to be a build status badge. I tried the URL structure for a workflow badge, using workflow I can't see where I'm going wrong, but if someone knows how to get a workflow badge working I'm guessing we could split The following works for a build status badge: <a href="https://circleci.com/gh/codidact/qpixel"><img src="https://circleci.com/gh/codidact/qpixel.svg?style=svg" alt="CircleCI Build Status"></a> However, the following doesn't seem to work for a workflow status badge: <a href="https://circleci.com/gh/codidact/qpixel"><img src="https://circleci.com/gh/codidact/qpixel/test_lint?style=svg" alt="CircleCI Build Status"></a> giving That was omitting the <a href="https://circleci.com/gh/codidact/qpixel"><img src="https://circleci.com/gh/codidact/qpixel/test_lint.svg?style=svg" alt="CircleCI Build Status"></a> |
Having separate badges for results of testing Ruby 3.1 and 3.2 seems impossible with CircleCI without ongoing manual workarounds with separate branches, so I've left just the single badge for now. Splitting into 2 might be worth considering once we move away from CircleCI. Previously the Ruby versions supported were mentioned only in If you're happy to leave the Docker configuration using 3.1 until we update the minimum supported version to 3.2 on 2025-04-01, is this pull request ready to merge now? |
Currently we test Ruby 2.7 and Ruby 3.1. Ruby 3.1 will reach end of life on 2025-03-31, and Ruby 2.7 has already passed end of life.
This pull request stops testing Ruby 2.7 and starts testing Ruby 3.2. The intention is that we will continue to test the oldest minor version that is still supported (has not reached end of life) plus the minor version after that, so that the tests ensure we are always ready to stop using a version when it reaches end of life.
For example, on 2025-04-01 when Ruby 3.1 is no longer supported, we can switch from testing 3.1 and 3.2 to testing 3.2 and 3.3.