Remove useless content (#76) #77
Conversation
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
=========================================
Coverage 12.67% 12.67%
Complexity 47 47
=========================================
Files 82 82
Lines 1862 1862
Branches 91 91
=========================================
Hits 236 236
Misses 1614 1614
Partials 12 12
Continue to review full report at Codecov.
|
|
Out of curiosity, will these PR's work fine with the latest build tools as I updated in my PR #73? Granted, I still have to figure out what's wrong with Travis but after that's worked out, will it cause any issues with the PR's you've been submitting, @AkshayCHD? |
| @@ -40,10 +41,6 @@ | |||
| import retrofit2.Callback; | |||
| import retrofit2.Response; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Should we be removing the javadocs that give credit to whoever created the class though, even if it's boilerplate from Android Studio?
There was a problem hiding this comment.
We could update them to all follow a standard date format and have more information regarding the class so it's not just the creator information.
There was a problem hiding this comment.
/**
* The {@link AppCompatActivity} class responsible for displaying {@link Droplet} information.
*
* @author the-dagger on 11/26/2016
*/Maybe something like this?
There was a problem hiding this comment.
@alcha yes as I have only removed some stuff that was not needed so i believe there won't be any issue, even if there is, the conflicts for such PRs could be resolved easily.
About removing the creator comments, they are quite inconsistent as the name mentioned there might not coincide with our real name or our github username and also just giving credit to the one who created that file and not to the ones who maintain and enhance it is not correct in my opinion.
There was a problem hiding this comment.
Then we can change it to show who created it and then who now maintains it. Especially if the majority of the code remaining is still written by the original author.
There was a problem hiding this comment.
/**
* The {@link AppCompatActivity} class responsible for displaying {@link Droplet} information.
*
* @author created by the-dagger on 11/26/2016, maintained by AkshayCHD
*/There was a problem hiding this comment.
@alcha currently the project is small but still we have alot of people who contributed in the past and there would be many who would be contributing in the future. I see no use of maintaining this record when all the information about each and eery contribution is avaliable on github.
There was a problem hiding this comment.
Fair enough, it's a difference of opinion then.
In that case, we'll have to leave it to @the-dagger and @championswimmer to decide.
There was a problem hiding this comment.
Yaa, it is better to leave it to them
|
@the-dagger @championswimmer please have a look |
|
Please make some constructive contributions from the future. Not just for the sake of raking some BOSS bounties or green streaks on Github. This is the most pointless PR I have seen till now. Especially with all the authorship removal. |
|
@championswimmer sorry you felt that way, i had no such intentions, there were some unused import statements and variables that were there in the code so i thought that they need to be removed, and about the authorship comments, I contributed in a project at FOSSASIA, there whever i made a pr the maintainer asked me to remove authorship comments very first so i thought same would apply here. |
fixes #76